Skip to content

Comments

Merge release/dev17.6 to main#67507

Merged
dotnet-bot merged 2 commits intomainfrom
merges/release/dev17.6-to-main
Mar 28, 2023
Merged

Merge release/dev17.6 to main#67507
dotnet-bot merged 2 commits intomainfrom
merges/release/dev17.6-to-main

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.6 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.6-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.6
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.6-to-main --force

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot merged commit 8bfc357 into main Mar 28, 2023
@ghost ghost added this to the Next milestone Mar 28, 2023
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
jjonescz added a commit that referenced this pull request Dec 16, 2025
Closes #67153.

The assert was uncommented already in the original fix
(#67157),
but then it got commented again via automatic code flow
(#67507).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants