Remove descendent node tracking from SyntaxEditor #67314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
CyrusNajmabadi
force-pushed
the
syntaxEditor
branch
from
b41b5f1 to
0985fc2
Compare
CyrusNajmabadi
commented
Mar 15, 2023
| destinationEditor.SemanticModel.Compilation, | ||
| node, | ||
| node.GetCurrentNode(newDestination), | ||
| node.GetAnnotatedNodes(s_destinationNodeAnnotation).FirstOrDefault(), |
Member
Author
There was a problem hiding this comment.
this was the bad line. They were basically trying to find this totally fresh node in the current root. but that totally fresh node was already morphed into a different node when teh replacement happened. Trivial fix is to just use our own annotation to track it, instead of the editor tracking all nodes.
Member
Author
ToddGrun
reviewed
Mar 15, 2023
Contributor
Member
Author
hrmm... i would think so. otehrwise i'm not sure how we would find the node after edits... teh tracking of change.OriginalNode seems very important... |
ToddGrun
reviewed
Mar 15, 2023
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Mar 29, 2023
arunchndr
added a commit
that referenced
this pull request
Mar 29, 2023
Revert "Remove descendent node tracking from SyntaxEditor #67314" from 17.6
mavasani
added
the
Performance-Scenario-Diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is showing up as extremely expensive in code action application, as some code actions track the whole tree, which adds hundreds of thousands of nodes to a CWT with annotations.
We're reverting back to the original design/impl here as it's extremely trivial and has almost no perf overhead. The single case that needed this behavior is much better served by a dedicated 2-line fix within the feature itself.