Skip to content

Skip flaky integration tests #67246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
genlu merged 1 commit into from
Mar 9, 2023
Merged

Skip flaky integration tests #67246

genlu merged 1 commit into from
Mar 9, 2023

Conversation

@genlu
Copy link
Member

@genlu genlu commented Mar 9, 2023

Tracking issues:
#67244
#67245

@genlu genlu requested a review from a team as a code owner March 9, 2023 18:20
@ghost ghost added the Area-Infrastructure label Mar 9, 2023
@sharwell
Copy link
Contributor

sharwell commented Mar 9, 2023

This is going to be an annoying conflict with #67020 . Can you at least restrict this to just the Skip attributes?

@genlu
Copy link
Member Author

genlu commented Mar 9, 2023

@sharwell done

@genlu genlu enabled auto-merge March 9, 2023 19:45
allisonchou
allisonchou approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@allisonchou allisonchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gen!

@genlu genlu merged commit cc8e2f1 into dotnet:main Mar 9, 2023
@ghost ghost added this to the Next milestone Mar 9, 2023
@genlu genlu deleted the Flaky branch March 9, 2023 21:55
@allisonchou allisonchou modified the milestones: Next, 17.6 P3 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@allisonchou allisonchou allisonchou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

17.6 P3

Development

Successfully merging this pull request may close these issues.

4 participants

@genlu @sharwell @CyrusNajmabadi @allisonchou