Skip to content

Revert "Disable diagnostics in the preview window" #67037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharwell merged 1 commit into from
Feb 24, 2023
Merged

Revert "Disable diagnostics in the preview window" #67037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ics/AbstractPushOrPullDiagnosticsTaggerProvider.SingleDiagnosticKindPullTaggerProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ private async Task ProduceTagsAsync(
if (document == null)
return;

if (document.Project.Solution.Workspace.Kind == WorkspaceKind.Preview)
return;

var snapshot = documentSpanToTag.SnapshotSpan.Snapshot;

var project = document.Project;
Expand Down
6 changes: 3 additions & 3 deletions src/EditorFeatures/Test/Preview/PreviewWorkspaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ public async Task TestPreviewDiagnosticTagger()
}

[WpfFact]
public async Task TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork()
public async Task TestPreviewDiagnosticTaggerInPreviewPane()
{
// TODO: WPF required due to https://github.com/dotnet/roslyn/issues/46153
using var workspace = TestWorkspace.CreateCSharp("class { }", composition: EditorTestCompositions.EditorFeaturesWpf);
Expand All @@ -173,7 +173,7 @@ public async Task TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork()
var newDocument = oldDocument.WithText(oldText.WithChanges(new TextChange(new TextSpan(0, oldText.Length), "class C { }")));

// create a diff view
WpfTestRunner.RequireWpfFact($"{nameof(TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork)} creates a {nameof(DifferenceViewerPreview)}");
WpfTestRunner.RequireWpfFact($"{nameof(TestPreviewDiagnosticTaggerInPreviewPane)} creates a {nameof(DifferenceViewerPreview)}");

var previewFactoryService = (PreviewFactoryService)workspace.ExportProvider.GetExportedValue<IPreviewFactoryService>();
using var diffView = await previewFactoryService.CreateChangedDocumentPreviewViewAsync(oldDocument, newDocument, CancellationToken.None);
Expand Down Expand Up @@ -211,7 +211,7 @@ public async Task TestPreviewDiagnosticTaggerInPreviewPaneDoesNotWork()
// check left buffer
var leftSnapshot = leftBuffer.CurrentSnapshot;
var leftSpans = leftTagger.GetTags(leftSnapshot.GetSnapshotSpanCollection()).ToList();
Assert.Equal(0, leftSpans.Count);
Assert.Equal(1, leftSpans.Count);

// check right buffer
var rightSnapshot = rightBuffer.CurrentSnapshot;
Expand Down