Remove the PreviewWorkspace SolutionCrawler functionality #67027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Feb 23, 2023
|
|
||
| [WorkItem(923196, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/923196")] | ||
| [WpfFact] | ||
| public async Task TestPreviewDiagnostic() |
Member
Author
There was a problem hiding this comment.
pull tagger test is below. this one was testing the push/solution-crawler version.
CyrusNajmabadi
commented
Feb 24, 2023
| workspace.TryApplyChanges(workspace.CurrentSolution.WithAnalyzerReferences(new[] { DiagnosticExtensions.GetCompilerDiagnosticAnalyzerReference(LanguageNames.CSharp) })); | ||
|
|
||
| // set up listener to wait until diagnostic finish running | ||
| _ = workspace.ExportProvider.GetExportedValue<IDiagnosticService>(); |
Member
Author
There was a problem hiding this comment.
was previously using push. updated to pull below.
CyrusNajmabadi
commented
Feb 24, 2023
| // We rely on LSP to query us for diagnostics when things have changed and poll us for changes that might | ||
| // have happened to the project or closed files outside of VS. However, we still need to create the analyzer | ||
| // so that the map contains the analyzer to run when pull diagnostics asks. | ||
| return GlobalOptions.IsLspPullDiagnostics() ? NoOpIncrementalAnalyzer.Instance : analyzer; |
Member
Author
There was a problem hiding this comment.
same logic a before. i just rejiggered. in both paths below we were adding hte item to the map. i pulled that above, and then just changed the logic if the NoOp analyzer is returned or the actual instance.
dibarbet
approved these changes
Feb 24, 2023
Contributor
|
Merging to facilitate lightbulb performance measurements with this change. |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SolutionCrawler here serves no purpose. The preview window is already only in one of two modes:
So yaay, we just get to ditch this.
There is still work to be done to get the pull-tagging in the preview window to do the computation in OOP, not in proc. But that's upcoming.