Skip to content

Port Rename and Formatting tests to the new framework #67020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharwell merged 11 commits into from
Mar 15, 2023
Merged

Port Rename and Formatting tests to the new framework #67020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab0f5dd
Port Rename and Formatting tests to the new framework
sharwell Feb 23, 2023
102550b
Wait for InlineRenameFlyout as part of rename
sharwell Feb 24, 2023
44cc377
Verify text and caret consistently
sharwell Feb 24, 2023
5bb976a
Fix syntax errors in test inputs
sharwell Feb 24, 2023
d194d69
Send rename keystrokes without activation to the old UI
sharwell Feb 27, 2023
4794845
Fix logic in CanRenameAttributePrefix
sharwell Feb 27, 2023
8126649
Merge remote-tracking branch 'dotnet/main' into port-tests
sharwell Feb 28, 2023
026a44f
Port automatic brace completion tests to the new integration test fra…
sharwell Feb 28, 2023
d84150d
Make sure to reset options that are configured by tests
sharwell Feb 28, 2023
8ed7879
Merge remote-tracking branch 'dotnet/main' into port-tests
sharwell Mar 14, 2023
7b45a1e
Support multiple outcomes in VerifyAttributeNotCapitalizedRename
sharwell Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/wiki/Manual-Testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ When doing a test pass, copy this page and consider using these status indicator
| **Typing** | :fast_forward: **General Typing**<br />- Type and paste new constructs<br />- Nothing interferes with verbatim typing | | | |
| | :mag: :fast_forward: **Completion**<br />- Typing new keyword/construct names<br />- Dotting off of new constructs<br />- Matching part of the identifier is highlighted (including word prefix matches) [Visual Studio 2015 Update 1]<br />- Target type preselection [Visual Studio 2017]<br />IntelliSense filtering [Visual Studio 2017] | | | |
| | :fast_forward: **Formatting** <br />- Spacing in and around new constructs<br />- Spacing options<br />- Format Document command<br /> `Tools > Options` settings should be respected | | | |
| | :fast_forward: **Automatic Brace Completion** (*C# only*) <br />- Auto-insert close brace<br />- Shift+Enter commit of IntelliSense and any pending brace completion sessions (Currently C# only: https://github.com/dotnet/roslyn/issues/18065) | | | N/A |
| | :fast_forward: **Automatic Brace Completion** (*C# only*) <br />- Auto-insert close brace<br />- Shift+Enter commit of IntelliSense and any pending brace completion sessions | | | N/A |
| | :fast_forward: **Indentation** <br />- Typing `Enter` in an unfinished statement indents the next line | | | |
| **Navigating** | :mag: :fast_forward: **Go To Definition** <br />- F12 from callsites to definition<br />- Ctrl+click [Visual Studio 2017 version 15.4] | | | |
| | :fast_forward: **Go To Implementation** <br />- Ctrl+F12 to jump from virtual members to their implementations<br />- Jump from inheritable types to their implementations | | | N/A |
Expand Down
5 changes: 1 addition & 4 deletions src/Features/Core/Portable/Rename/SymbolicRenameInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,8 @@ private bool CanRenameAttributePrefix(string triggerText)
// Ok, the symbol is good. Now, make sure that the trigger text starts with the prefix
// of the attribute. If it does, then we can rename just the attribute prefix (otherwise
// we need to rename the entire attribute).
#pragma warning disable IDE0059 // Unnecessary assignment of a value - https://github.com/dotnet/roslyn/issues/45895
var nameWithoutAttribute = GetWithoutAttributeSuffix(this.Symbol.Name);

return triggerText.StartsWith(triggerText); // TODO: Always true? What was it supposed to do?
#pragma warning restore IDE0059 // Unnecessary assignment of a value
return triggerText.StartsWith(nameWithoutAttribute);

bool IsRenamingAttributeTypeWithAttributeSuffix()
{
Expand Down
Loading