Add ExternalAccess.RazorCompiler project with host outputs API
#65831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add host outputs to exerimental API surface - Enable internal hosts outputs in generator driver
ghost
added
the
Youssef1313
reviewed
Dec 7, 2022
Youssef1313
reviewed
Dec 7, 2022
src/Compilers/Core/Experimental/Microsoft.CodeAnalysis.Experimental.csproj
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Dec 7, 2022
333fred
reviewed
Jan 6, 2023
...ools/ExternalAccess/RazorCompiler/Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.csproj
Show resolved
Hide resolved
333fred
reviewed
Jan 6, 2023
333fred
reviewed
Jan 6, 2023
Member
There was a problem hiding this comment.
Please add a line like https://github.com/dotnet/roslyn/blob/main/.github/CODEOWNERS for the new project (with roslyn-compiler as the owner)
jjonescz
changed the title
ExternalAccess.RazorCompiler project with host outputs API
chsienki
approved these changes
Jan 9, 2023
333fred
approved these changes
Jan 9, 2023
jjonescz
added a commit
to jjonescz/roslyn
that referenced
this pull request
Feb 1, 2023
…net#65831) * Initial experimental API project - Add host outputs to exerimental API surface - Enable internal hosts outputs in generator driver * Move project, add nuget package, add to sln * PR Feedback * Update unreachable calls * Update nullability * Suppress unused parameter warning * Add project to `Compilers.slnf` * Move to new ExternalAccess project * Remove an old IVT * Add project to compiler solutions * Assign project to Roslyn compiler team Co-authored-by: Chris Sienkiewicz <[email protected]>
jjonescz
added a commit
that referenced
this pull request
Feb 7, 2023
) * Initial experimental API project - Add host outputs to exerimental API surface - Enable internal hosts outputs in generator driver * Move project, add nuget package, add to sln * PR Feedback * Update unreachable calls * Update nullability * Suppress unused parameter warning * Add project to `Compilers.slnf` * Move to new ExternalAccess project * Remove an old IVT * Add project to compiler solutions * Assign project to Roslyn compiler team Co-authored-by: Chris Sienkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces and closes #64478.
Adds new
ExternalAccess.RazorCompilerproject referencing only the compiler layer of Roslyn so it can be referenced from Razor source generator (unlike the existingExternalAccess.Razorproject which references also Workspaces).This new project contains a new host outputs API for Razor source generator to communicate with Razor tooling.