[Port] Gracefully handle additional locations in DiagnosticData.Create#65532
Merged
arunchndr merged 1 commit intodotnet:release/dev17.4from Nov 21, 2022
Merged
[Port] Gracefully handle additional locations in DiagnosticData.Create#65532arunchndr merged 1 commit intodotnet:release/dev17.4from
arunchndr merged 1 commit intodotnet:release/dev17.4from
Conversation
Fixes [AB#1676229](https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1676229) Handle additional location in different project from the primary location project as well additional location in a document which was subsequently removed from the solution. Verified that the added unit test fails prior to the product fix.
ghost
added
the
This was referenced Nov 21, 2022
Closed
arunchndr
approved these changes
Nov 21, 2022
Contributor
|
I cannot imagine how rename tests will be broken by this. Rerunning. At this point, given our infra fixes are landing only in 17.5, we are going to stick to investing in flakiness there, if rerun succeeds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #65434 to
release/dev17.4Fixes AB#1676229
Handle additional location in different project from the primary location project as well additional location in a document which was subsequently removed from the solution.
Verified that the added unit test fails prior to the product fix.