Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VS Platform NuGet package version #64667

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

genlu
Copy link
Member

@genlu genlu commented Oct 12, 2022

the currently referenced version couldn't be published to NuGet.org due internal infra issue, so update the reference to the newer version that's available to avoid restore warning when using Roslyn package.

warning NU1603: Microsoft.CodeAnalysis.EditorFeatures.Text 4.4.0-3.final depends on Microsoft.VisualStudio.CoreUtility (>= 17.4.136-preview) but Microsoft.VisualStudio.CoreUtility 17.4.136-preview was not found. An approximate best match of Microsoft.VisualStudio.CoreUtility 17.4.203-preview was resolved.

triggering a test insertion to make sure it doesn't break anything
https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/429134

@Sergio0694
Copy link
Contributor

"the currently referenced version couldn't be published to NuGet.org due internal infra issue"

Hey @genlu, do you know if that version still planned to be released eventually, or if current consumers of that just should switch to a toolset version from the nightly feed until the next 17.4 preview drops (or GA, not sure if there's another preview coming)? If it's the latter, would you know which exact Microsoft.Net.Compilers.Toolset version is the one matching the Roslyn build bundled with VS 17.4 P3, so we can use that for the time being? Thank you! 😄

@genlu
Copy link
Member Author

genlu commented Oct 13, 2022

@Sergio0694 I believe platform packages of vesion 17.4.136-preview will not be published to NuGet.org. But this won't affect any current consumers of Roslyn 17.4 packages, since those published to nuget.org doesn't reference this version, and ones that do are not published on nuget.org (i.e. they are on vs and dotnet feeds).

would you know which exact Microsoft.Net.Compilers.Toolset version is the one matching the Roslyn build bundled with VS 17.4 P3

I'm not sure I understand why you need to match the version, but it's 4.4.0-3.22505.14

@genlu genlu requested a review from a team as a code owner October 14, 2022 18:53
@genlu genlu merged commit 0d6b4d8 into dotnet:release/dev17.4 Oct 14, 2022
@genlu genlu deleted the BumpEditorPackages branch October 14, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants