Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reordering parameters, inserting, and deleting parameters #64596

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Allow reordering parameters, inserting, and deleting parameters #64596

merged 2 commits into from
Nov 11, 2022

Conversation

davidwengier
Copy link
Contributor

Part of #59264

This unblocks reordering parameters, and makes it work the same was as renaming them - ie, requires the UpdateParameters capability, and reports RenamingNotSupported rude edit otherwise.

This also allows for inserts and deletes of parameters, which was already mostly supported, but test coverage was not good, so I added some more, and fixed a bug.

@davidwengier davidwengier requested review from a team as code owners October 10, 2022 05:33
@davidwengier davidwengier mentioned this pull request Oct 10, 2022
Open
@build-analysis build-analysis bot mentioned this pull request Oct 10, 2022
Closed
@davidwengier
Copy link
Contributor Author

@tmat PTAL

@tmat
Copy link
Member

tmat commented Nov 10, 2022 

                    ReportError(RudeEditKind.Move);

Seems like something that we can easily implement after this PR is merged.

Refers to: src/Features/CSharp/Portable/EditAndContinue/CSharpEditAndContinueAnalyzer.cs:2344 in fcb7bd3. [](commit_id = fcb7bd3, deletion_comment = False)

tmat
tmat approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier enabled auto-merge (squash) November 11, 2022 04:02
@davidwengier davidwengier merged commit 7a25fe6 into dotnet:main Nov 11, 2022
@ghost ghost added this to the Next milestone Nov 11, 2022
@davidwengier davidwengier deleted the EnCReorderInsertDeleteParameters branch November 13, 2022 04:40
@allisonchou allisonchou mentioned this pull request Nov 17, 2022
Closed
@allisonchou allisonchou modified the milestones: Next, 17.5 P2 Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.5 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwengier @tmat @allisonchou