-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Experimental api support for HostOutputs #64478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Collections.Immutable; | ||
| using System.Threading; | ||
| using Microsoft.CodeAnalysis.PooledObjects; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Experimental | ||
| { | ||
| public static partial class ExperimentalApis | ||
| { | ||
| public static void RegisterHostOutput<TSource>(ref this IncrementalGeneratorInitializationContext @this, IncrementalValuesProvider<TSource> source, Action<HostProductionContext, TSource, CancellationToken> action) | ||
| { | ||
| source.Node.RegisterOutput(new HostOutputNode<TSource>(source.Node, action)); | ||
| } | ||
|
|
||
| public static ImmutableArray<(string, string)> GetHostOutputs(this GeneratorRunResult runResult) => runResult.HostOutputs; | ||
| } | ||
|
|
||
| public readonly struct HostProductionContext | ||
| { | ||
| internal readonly ArrayBuilder<(string, string)> Outputs; | ||
|
|
||
| internal HostProductionContext(ArrayBuilder<(string, string)> outputs) | ||
| { | ||
| Outputs = outputs; | ||
| } | ||
|
|
||
| public void AddOutput(string name, string value) => Outputs.Add((name, value)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Collections.Immutable; | ||
| using System.Diagnostics; | ||
| using System.Text; | ||
| using System.Threading; | ||
| using Microsoft.CodeAnalysis.Experimental; | ||
| using Microsoft.CodeAnalysis.PooledObjects; | ||
| using Roslyn.Utilities; | ||
| using TOutput = System.Collections.Immutable.ImmutableArray<(string, string)>; | ||
|
|
||
| namespace Microsoft.CodeAnalysis | ||
| { | ||
| internal sealed class HostOutputNode<TInput> : IIncrementalGeneratorOutputNode, IIncrementalGeneratorNode<TOutput> | ||
| { | ||
| private readonly IIncrementalGeneratorNode<TInput> _source; | ||
|
|
||
| private readonly Action<HostProductionContext, TInput, CancellationToken> _action; | ||
|
|
||
| public HostOutputNode(IIncrementalGeneratorNode<TInput> source, Action<HostProductionContext, TInput, CancellationToken> action) | ||
| { | ||
| _source = source; | ||
| _action = action; | ||
| } | ||
|
|
||
| public IncrementalGeneratorOutputKind Kind => (IncrementalGeneratorOutputKind)0b100000; // several steps higher than IncrementalGeneratorOutputKind.Implementation | ||
|
|
||
| public NodeStateTable<TOutput> UpdateStateTable(DriverStateTable.Builder graphState, NodeStateTable<TOutput> previousTable, CancellationToken cancellationToken) | ||
| { | ||
| string stepName = "HostOutput"; | ||
| var sourceTable = graphState.GetLatestStateTableForNode(_source); | ||
| if (sourceTable.IsCached) | ||
| { | ||
| if (graphState.DriverState.TrackIncrementalSteps) | ||
| { | ||
| return previousTable.CreateCachedTableWithUpdatedSteps(sourceTable, stepName, EqualityComparer<TOutput>.Default); | ||
| } | ||
| return previousTable; | ||
| } | ||
|
|
||
| var nodeTable = graphState.CreateTableBuilder(previousTable, stepName, EqualityComparer<TOutput>.Default); | ||
| foreach (var entry in sourceTable) | ||
| { | ||
| var inputs = nodeTable.TrackIncrementalSteps ? ImmutableArray.Create((entry.Step!, entry.OutputIndex)) : default; | ||
| if (entry.State == EntryState.Removed) | ||
| { | ||
| nodeTable.TryRemoveEntries(TimeSpan.Zero, inputs); | ||
| } | ||
| else if (entry.State != EntryState.Cached || !nodeTable.TryUseCachedEntries(TimeSpan.Zero, inputs)) | ||
| { | ||
| ArrayBuilder<(string, string)> output = ArrayBuilder<(string, string)>.GetInstance(); | ||
| HostProductionContext context = new HostProductionContext(output); | ||
| var stopwatch = SharedStopwatch.StartNew(); | ||
| _action(context, entry.Item, cancellationToken); | ||
| nodeTable.AddEntry(output.ToImmutableAndFree(), EntryState.Added, stopwatch.Elapsed, inputs, EntryState.Added); | ||
| } | ||
| } | ||
|
|
||
| return nodeTable.ToImmutableAndFree(); | ||
| } | ||
|
|
||
| public void AppendOutputs(IncrementalExecutionContext context, CancellationToken cancellationToken) | ||
| { | ||
| // get our own state table | ||
| Debug.Assert(context.TableBuilder is not null); | ||
| var table = context.TableBuilder.GetLatestStateTableForNode(this); | ||
|
|
||
| // add each non-removed entry to the context | ||
| foreach (var (list, state, _, _) in table) | ||
| { | ||
| if (state != EntryState.Removed) | ||
| { | ||
| context.HostOutputBuilder.AddRange(list); | ||
| } | ||
| } | ||
|
|
||
| if (context.GeneratorRunStateBuilder.RecordingExecutedSteps) | ||
| { | ||
| context.GeneratorRunStateBuilder.RecordStepsFromOutputNodeUpdate(table); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| IIncrementalGeneratorNode<TOutput> IIncrementalGeneratorNode<TOutput>.WithComparer(IEqualityComparer<TOutput> comparer) => throw ExceptionUtilities.Unreachable; | ||
|
|
||
| public IIncrementalGeneratorNode<TOutput> WithTrackingName(string name) => throw ExceptionUtilities.Unreachable; | ||
|
|
||
| void IIncrementalGeneratorNode<TOutput>.RegisterOutput(IIncrementalGeneratorOutputNode output) => throw ExceptionUtilities.Unreachable; | ||
|
|
||
|
|
||
| } | ||
| } |
18 changes: 18 additions & 0 deletions
18
src/Compilers/Core/Experimental/Microsoft.CodeAnalysis.Experimental.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
chsienki marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| <IsPackable>true</IsPackable> | ||
| <PackageId>Microsoft.CodeAnalysis.Experimental</PackageId> | ||
| <PackageDescription> | ||
| This package provides access to experimental Microsoft .NET Compiler Platform ("Roslyn") APIs. | ||
| The APIs exposed in this package are not supported in any way, and may be changed or removed without notice. | ||
| </PackageDescription> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\Portable\Microsoft.CodeAnalysis.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to add an image load to Razor scenarios and at some ponit Rsolyn ones too. We should pre-clear this with the VS perf team.