Don't place bogus data in an in/out variable in venus#64148
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Sep 20, 2022
Merged
Don't place bogus data in an in/out variable in venus#64148CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
ghost
added
the
CyrusNajmabadi
commented
Sep 20, 2022
|
|
||
| // Next, we'll check to see if there is actually a DataTip for this candidate. | ||
| // If there is, we'll map this span back to the DataBuffer and return it. | ||
| pSpan[0] = candidateSpan.ToVsTextSpan(); |
Contributor
Author
There was a problem hiding this comment.
problem was here. we were placing a span in our subject-buffer coordinates into an in/out parameter that is referring to the surface buffer. If we ended up succeeding below, this wasn't a problem, as we'd overwrite this. But if we failed, we'd leave this bogus data in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.