Remove the usage of grid in Inheritance margin#64138
Merged
Cosifne merged 2 commits intodotnet:mainfrom Sep 20, 2022
Merged
Conversation
ghost
added
the
jmarolf
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the inheritance margin is moved into the left selection margin #63992
It would become like
This is because in left selection margin http://index/?leftProject=Microsoft.VisualStudio.Platform.VSEditor&leftSymbol=gsp1xdezk7ju
It has already set the LayoutTransform.
And before that, Left margin, doesn't do that for us (so we have a grid and set it by ourselves)
Because left selection margin already change the layout, if we still do that, we will scale the glyph twice.
Remove the grid would fix the issue.