Improve SymbolDisplay to handle operator symbols that are not valid operators for the target language. #64109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perators for the target language. Also ensure SymbolDisplay for VB can handle symbols for VB checked built-in operators after the recent change in dotnet#63604. This fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1615080.
Contributor
Author
|
@333fred, @dotnet/roslyn-compiler Please review |
jaredpar
reviewed
Sep 19, 2022
| if (sourceUserDefinedOperatorSymbolBase is SourceUserDefinedConversionSymbol) | ||
| { | ||
| addUserDefinedConversionName(symbol, operatorName); | ||
| addUserDefinedConversionName(symbol, tryGetUserDefinedConversionTokenKind(operatorName), operatorName); |
Member
There was a problem hiding this comment.
There is an implicit dependency here that tryGetUserDefinedConversionTokenKind does not return SyntaxKind.None. Why is it safe to assume that on this code path but other code paths explicitly handle its return? #Resolved
Contributor
Author
There was a problem hiding this comment.
Why is it safe to assume that on this code path but other code paths explicitly handle its return?
This code path handles C# symbols (see is SourceUserDefinedOperatorSymbolBase check above, for those the helper is expected to always succeed.
jaredpar
approved these changes
Sep 19, 2022
Contributor
Author
|
@dotnet/roslyn-compiler For the second review. |
1 similar comment
Contributor
Author
|
@dotnet/roslyn-compiler For the second review. |
333fred
approved these changes
Sep 21, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure SymbolDisplay for VB can handle symbols for VB checked built-in operators after the recent change in #63604. This fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1615080.