Skip to content

Comments

Deprecate public constructors of various diagnostic analysis context types#64083

Merged
mavasani merged 1 commit intodotnet:mainfrom
mavasani:DeprecateContextCtors
Jan 4, 2023
Merged

Deprecate public constructors of various diagnostic analysis context types#64083
mavasani merged 1 commit intodotnet:mainfrom
mavasani:DeprecateContextCtors

Conversation

@mavasani
Copy link
Contributor

@mavasani mavasani commented Sep 16, 2022

Fixes #63440

NOTE: This PR is built on top of #63447 to avoid merge conflicts. The only relevant commit for this PR is a101a16

@mavasani mavasani requested review from a team as code owners September 16, 2022 12:26
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Sep 16, 2022

@mavasani It looks like we wanted to wait until .NET 8 for this change. See #63440 (comment)

@mavasani
Copy link
Contributor Author

mavasani commented Sep 19, 2022

@mavasani It looks like we wanted to wait until .NET 8 for this change. See #63440 (comment)

Ah, thanks. Sorry, I missed that part. Marking the PR as blocked.

@jcouv jcouv marked this pull request as draft October 20, 2022 18:10
@jcouv
Copy link
Member

jcouv commented Oct 20, 2022

Marked as draft to make room in our review queue. Please mark as ready for review and ping when appropriate

@mavasani mavasani marked this pull request as ready for review December 7, 2022 05:58
@mavasani mavasani removed the Blocked label Dec 7, 2022
@mavasani
Copy link
Contributor Author

mavasani commented Dec 7, 2022

@mavasani It looks like we wanted to wait until .NET 8 for this change. See #63440 (comment)

@AlekseyTs It seems now main is targeting .NET8. This PR should be ready for review.

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Dec 8, 2022 •
edited
Loading

@mavasani Could you rebase the branch on top of the current main to eliminate commits that have been merged already?

@mavasani mavasani force-pushed the DeprecateContextCtors branch from a101a16 to c75c873 Compare December 13, 2022 06:09
@mavasani
Copy link
Contributor Author

mavasani commented Dec 13, 2022

@mavasani Could you rebase the branch on top of the current main to eliminate commits that have been merged already?

Thanks @AlekseyTs - I have rebased the branch.

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Dec 13, 2022

Done with review pass (commit 1)

AlekseyTs
AlekseyTs approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@mavasani
Copy link
Contributor Author

mavasani commented Jan 4, 2023

@dotnet/roslyn-compiler for second review - very trivial change.

@jcouv jcouv self-assigned this Jan 4, 2023
jcouv
jcouv approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@mavasani mavasani merged commit cde3f5c into dotnet:main Jan 4, 2023
@mavasani mavasani deleted the DeprecateContextCtors branch January 4, 2023 15:30
@ghost ghost added this to the Next milestone Jan 4, 2023
@allisonchou allisonchou mentioned this pull request Jan 11, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.6 P1 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Analyzers Area-Compilers

Projects

None yet

Milestone

17.6 P1

Development

Successfully merging this pull request may close these issues.

Deprecate all public constructors of various diagnostic analysis context types

4 participants

@mavasani @AlekseyTs @jcouv @Cosifne