Replace Razor Source Generator reference with one loaded from a VSIX#63912
Merged
tmat merged 9 commits intodotnet:mainfrom Sep 20, 2022
Merged
Replace Razor Source Generator reference with one loaded from a VSIX#63912tmat merged 9 commits intodotnet:mainfrom
tmat merged 9 commits intodotnet:mainfrom
Conversation
ghost
added
the
tmat
force-pushed
the
RazorSourceGen
branch
from
4d3f1ab to
d81aa5a
Compare
Member
Author
jaredpar
reviewed
Sep 12, 2022
jaredpar
approved these changes
Sep 13, 2022
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Can we add tests for this?
src/VisualStudio/Core/Def/Diagnostics/VisualStudioDiagnosticAnalyzerProvider.Factory.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Diagnostics/IVisualStudioDiagnosticAnalyzerProviderFactory.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Diagnostics/VisualStudioDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Diagnostics/VisualStudioDiagnosticAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/ProjectSystem/VisualStudioProjectFactory.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Sep 16, 2022
src/VisualStudio/Core/Test/ProjectSystemShim/VisualStudioProjectTests/AnalyzerReferenceTests.vb
Outdated
Show resolved
Hide resolved
| return GetOrCreateProviderOnMainThread(); | ||
| } | ||
|
|
||
| private VisualStudioDiagnosticAnalyzerProvider GetOrCreateProviderOnMainThread() |
Member
There was a problem hiding this comment.
Just inline this into the earlier function at this point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analyzers are being added by the project system, replace Razor source generator and its dependencies as they ship in SDK with new source generator and its dependencies from VSIX.
Related Razor change: dotnet/razor#6821