Skip to content

Add correctness check that only runs analyzers #62035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dibarbet merged 10 commits into from
Jul 29, 2022
Merged

Add correctness check that only runs analyzers #62035

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
68d1c05
Add correctness check that only runs analyzers
dibarbet Jun 20, 2022
77ac388
Increase timeout
dibarbet Jun 21, 2022
52c69bb
Merge remote-tracking branch 'upstream/main' into split_correctness_a…
dibarbet Jun 21, 2022
eb39b1a
Update analyzers / format version
dibarbet Jun 22, 2022
b0dd4fa
Fix new formatting warnings
dibarbet Jun 22, 2022
9ce3240
Fix more warnings
dibarbet Jun 23, 2022
5bf9771
Fix another batch of warnings
dibarbet Jun 23, 2022
8c8ae70
Bump timeout in case restore takes a while
dibarbet Jun 23, 2022
55957ae
Merge remote-tracking branch 'upstream/main' into split_correctness_a…
dibarbet Jul 25, 2022
b688a61
Fix windows checkout task name
dibarbet Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,3 +268,17 @@ jobs:
parameters:
jobName: Correctness_Rebuild
configuration: Release

- job: Correctness_Analyzers
pool:
name: NetCore1ESPool-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
timeoutInMinutes: 30
steps:
- template: eng/pipelines/checkout-task.yml

- task: PowerShell@2
displayName: Build with analyzers
inputs:
filePath: eng/build.ps1
arguments: -restore -build -configuration Debug -prepareMachine -ci -binaryLog -runAnalyzers:$true -warnAsError:$true -properties "/p:RoslynEnforceCodeStyle=true"
Copy link
Member

@RikkiGibson RikkiGibson Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So getting all analyzer diagnostics in the solution on the command line requires emitting, etc.? is that correct? Just wondered if there was an msbuild target or something equivalent to "run code analysis on solution."

Copy link
Contributor

@jmarolf jmarolf Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someday when we are allowed to used github actions we could use: https://github.com/dotnet/code-analysis but for now I think this is the simplest approach.