Use 'Clear' to empty a CWT when on .net core #61952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
CyrusNajmabadi
commented
Jun 16, 2022
| // also, conditional weak table has a leak - https://github.com/dotnet/coreclr/issues/665 | ||
| // we create new conditional weak table every time netstandard as that's the only way it has to clear it. | ||
| #if NETSTANDARD | ||
| _projectCompilationsWithAnalyzers = new ConditionalWeakTable<Project, CompilationWithAnalyzers?>(); |
Member
Author
There was a problem hiding this comment.
assigning like this means the old value gets GC'ed which runs the finalizer for the CWT. the finalizer means everything this points at gets elevated to the next generation.
mavasani
approved these changes
Jun 16, 2022
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.