Fix Rune access issue on AspNetCoreVirtualChar #61875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Youssef1313
reviewed
Jun 14, 2022
src/Tools/ExternalAccess/AspNetCore/EmbeddedLanguages/AspNetCoreVirtualChar.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 14, 2022
CyrusNajmabadi
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rune is an internal shim with netstandard2.0 and accessing it throws an internal access exception. Expose integer value as RuneValue instead. I'm not sure whether RuneValue is necessary when Value already exists. I don't have code that uses RuneValue and it could be removed from this PR.
Also added equality implementations. I wanted to test equality of virtual chars and Equals uses Rune. Copying the Equals logic in my assembly is how I noticed this problem.