Skip to content

Polish async suggestions #61840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 14, 2022
Merged

Polish async suggestions #61840

merged 4 commits into from
Jun 14, 2022

Conversation

@DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented Jun 12, 2022

Follow up to #60528

  1. Do not supress snippets - user can have a type shortcut, e.g. vtask for ValueTask
  2. Show type if it contains valid task-like nested types
  3. Rename IsInTaskLikeTypeContext -> IsTaskLikeTypeContext to keep things consistent

@CyrusNajmabadi Would like you to look through

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner June 12, 2022 17:11
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jun 12, 2022
sharwell
sharwell reviewed Jun 13, 2022
View reviewed changes
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine overall. @CyrusNajmabadi to confirm behavior changes

@DoctorKrolic @sharwell
Static lambda
68d5511 
Co-authored-by: Sam Harwell <[email protected]>
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 14, 2022 07:40
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Jun 14, 2022

Thanks!

This was referenced Jun 14, 2022
Open
Closed
@DoctorKrolic
Copy link
Contributor Author

DoctorKrolic commented Jun 14, 2022

@CyrusNajmabadi Restart failing CI pls

@CyrusNajmabadi CyrusNajmabadi merged commit 6d15eeb into dotnet:main Jun 14, 2022
@ghost ghost added this to the Next milestone Jun 14, 2022
@DoctorKrolic DoctorKrolic deleted the async-suggestions-follow-up branch June 14, 2022 17:20
chsienki added a commit to chsienki/roslyn that referenced this pull request Jun 21, 2022
@chsienki
Revert "Merge pull request dotnet#61840 from DoctorKrolic/async-sugge…
396f513 
…stions-follow-up"

This reverts commit 6d15eeb, reversing
changes made to babbfb0.
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@sharwell sharwell sharwell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.3 P3

Development

Successfully merging this pull request may close these issues.

4 participants

@DoctorKrolic @CyrusNajmabadi @sharwell @RikkiGibson