Adjust implementation of user-defined conversion resolution according to the latest LDM decision #61754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the latest LDM decision Closes dotnet#61470. Related to dotnet#56753.
Contributor
Author
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review. |
2 similar comments
Contributor
Author
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review. |
Contributor
Author
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review. |
jcouv
reviewed
Jun 9, 2022
| [InlineData("implicit", true)] | ||
| [InlineData("explicit", false)] | ||
| [InlineData("explicit", true)] | ||
| public void ConsumeAbstractConversionOperator_11([CombinatorialValues("implicit", "explicit")] string op, bool needCast) |
Member
There was a problem hiding this comment.
Can we remove CombinatorialValues?
nit: useCast would make more sense than needCast #Resolved
Contributor
Author
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler For the second review. |
Contributor
Author
|
@RikkiGibson, @333fred, @dotnet/roslyn-compiler For the second review. |
Contributor
Author
|
@333fred, @RikkiGibson, @dotnet/roslyn-compiler For the second review. |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61470.
Related to #56753.
Test plan #60968