Require spaces within line span directives and relax LangVer check #61686

jcouv · 2022-06-03T15:57:42Z

Fixes #61663
Addresses the most urgent scenario in #61094

Corresponding spec update: dotnet/csharplang#6195

cston · 2022-06-03T16:35:44Z

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

        WRN_ObsoleteMembersShouldNotBeRequired = 9042,
        ERR_RefReturningPropertiesCannotBeRequired = 9043,

+        ERR_LineSpanDirectiveRequiresSpace = 9028,


ERR_LineSpanDirectiveRequiresSpace = 9028,

Consider moving to line 2074. #Closed

Not sure how I got the right number, but in the wrong place... ;-)

cston · 2022-06-03T16:47:57Z

src/Compilers/CSharp/Portable/CSharpResources.resx

    <value>The #line directive end position must be greater than or equal to the start position</value>
  </data>
+  <data name="ERR_LineSpanDirectiveRequiresSpace" xml:space="preserve">
+    <value>The #line span directive requires space before the first parenthesis, before the character offset and before the file name</value>


and

It looks like we typically include a comma for three or more items: ", and" #Closed

cston · 2022-06-03T16:56:04Z

src/Compilers/CSharp/Test/Syntax/Parsing/LineSpanDirectiveParsingTests.cs

+            EOF();
+        }
+
+        [Fact, WorkItem(61663, "https://github.com/dotnet/roslyn/issues/61663")]


WorkItem(61663, "#61663")

It feels like the [WorkItem] attribute belongs on the previous test rather than this one. #Closed

cston · 2022-06-03T16:57:59Z

src/Compilers/CSharp/Test/Syntax/Parsing/LineSpanDirectiveParsingTests.cs

+        }
+
+        [Fact, WorkItem(61663, "https://github.com/dotnet/roslyn/issues/61663")]
+        public void RequireSpace_MissingFilename()


RequireSpace_MissingFilename

Is this Incomplete_12? #Resolved

cston · 2022-06-03T16:58:14Z

src/Compilers/CSharp/Test/Syntax/Parsing/LineSpanDirectiveParsingTests.cs

+        }
+
+        [Fact, WorkItem(61663, "https://github.com/dotnet/roslyn/issues/61663")]
+        public void RequireSpace_MissingFilename_WithoutCharacterOffset()


RequireSpace_MissingFilename_WithoutCharacterOffset

Is this Incomplete_11? #Resolved

cston · 2022-06-03T16:59:59Z

src/Compilers/CSharp/Portable/Parser/DirectiveParser.cs


-            if (isActive)
-            {
-                lineKeyword = CheckFeatureAvailability(lineKeyword, MessageID.IDS_FeatureLineSpanDirective);


MessageID.IDS_FeatureLineSpanDirective

Can this MessageID be removed? #Resolved

cston · 2022-06-03T17:00:15Z

Can this resource be removed?

In reply to: 1146180483

Refers to: src/Compilers/CSharp/Portable/CSharpResources.resx:6673 in 78cbece. [](commit_id = 78cbece, deletion_comment = False)

cston · 2022-06-03T17:03:45Z

docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md

+For example, this would be valid: `#line(1,2)-(3,4)5"file.cs"`.
+
+In Visual Studio 17.3, the compiler requires spaces before the first parenthesis, the character
+offset and the file name.  


Consider adding a comma: ", and the file name." #Resolved

jcouv · 2022-06-03T19:38:15Z

@dotnet/roslyn-compiler for second review. Thanks

cston · 2022-06-03T19:41:36Z

docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md


+## Required spaces in #line span directives
+
+***Introduced in .NET SDK 7.0.100, Visual Studio 2022 version 17.3.***


.NET SDK 6.0.400?

jcouv · 2022-06-07T14:39:43Z

@dotnet/roslyn-compiler for second review. Thanks

jcouv · 2022-06-10T18:29:42Z

@dotnet/roslyn-compiler for second review. Thanks

jcouv · 2022-06-13T16:43:03Z

@dotnet/roslyn-compiler for second review. Thanks

chsienki · 2022-06-13T18:41:05Z

@jcouv Can confirm that razor generates valud #line directives according to these rules. https://github.com/dotnet/razor-compiler/blob/4cf24694112b70c35895666f159e25b07e60fb58/src/Microsoft.AspNetCore.Razor.Language/src/CodeGeneration/CodeWriterExtensions.cs#L151

jcouv · 2022-06-13T18:41:41Z

Awesome. Thanks @chsienki

jcouv added 2 commits June 3, 2022 08:54

Require spaces within line span directives

8f3e710

Remove LangVer check

78cbece

jcouv self-assigned this Jun 3, 2022

ghost added the Area-Compilers label Jun 3, 2022

cston reviewed Jun 3, 2022

View reviewed changes

jcouv added 2 commits June 3, 2022 10:10

Address feedback

f1b8872

comma

1d3490e

jcouv marked this pull request as ready for review June 3, 2022 17:14

jcouv requested a review from a team as a code owner June 3, 2022 17:14

cston approved these changes Jun 3, 2022

View reviewed changes

cston reviewed Jun 3, 2022

View reviewed changes

SDK version

a9f1fbd

chsienki approved these changes Jun 13, 2022

View reviewed changes

jcouv merged commit 65f8ef6 into dotnet:main Jun 13, 2022

jcouv deleted the line-space branch June 13, 2022 18:41

ghost added this to the Next milestone Jun 13, 2022

jcouv mentioned this pull request Jun 13, 2022

Allow the language version for generated files to 'float' #61094

Open

RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022

jcouv mentioned this pull request Jul 1, 2022

Enhanced #line directives should be supported independent of language version #61530

Closed


		## Required spaces in #line span directives

		*Introduced in .NET SDK 7.0.100, Visual Studio 2022 version 17.3.*

Require spaces within line span directives and relax LangVer check #61686

Require spaces within line span directives and relax LangVer check #61686

Uh oh!

Conversation

jcouv commented Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cston Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcouv Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

cston Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cston Jun 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cston Jun 3, 2022 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cston Jun 3, 2022 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cston Jun 3, 2022 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cston commented Jun 3, 2022 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cston Jun 3, 2022 • edited by jcouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jcouv commented Jun 3, 2022

Uh oh!

cston Jun 3, 2022

Choose a reason for hiding this comment

Uh oh!

jcouv commented Jun 7, 2022

Uh oh!

jcouv commented Jun 10, 2022

Uh oh!

jcouv commented Jun 13, 2022

Uh oh!

chsienki commented Jun 13, 2022

Uh oh!

jcouv commented Jun 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jcouv commented Jun 3, 2022 •

edited

Loading

cston Jun 3, 2022 •

edited

Loading

cston Jun 3, 2022 •

edited

Loading

cston Jun 3, 2022 •

edited

Loading

cston Jun 3, 2022 •

edited by jcouv

Loading

cston Jun 3, 2022 •

edited by jcouv

Loading

cston Jun 3, 2022 •

edited by jcouv

Loading

cston commented Jun 3, 2022 •

edited by jcouv

Loading

cston Jun 3, 2022 •

edited by jcouv

Loading