Couple of fixes for bulk suppression #6000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix a race condition in IDELatestDiagnosticGetter, when used is concurrent mode it might return incomplete set of diagnostics. This affects both FixAll behavior as bulk suppression from error list - we might drop diagnostics from the batch fix. 2. Thread in the cancellation token into bulk suppression batch fix computation - otherwise IDE becomes unresponsive on cancelling computation of suppressions fix.
Contributor
Author
Contributor
There was a problem hiding this comment.
Can you comment why this is the right thing? Nothing about there being a document or not indicates to me why we should be concurrent or not. Thanks!
Contributor
Author
|
Changes included in #6096, closing this one. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
Suppress CA1305 for `Guid.Parse`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDELatestDiagnosticGetter, when used is concurrent mode it might return incomplete set of diagnostics. This affects both FixAll behavior as well as bulk suppression from error list - we might drop diagnostics from the batch fix.