Remove dependency on EditorFeatures from Remote.ServiceHub project #59059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
@ryzngard ptal |
CyrusNajmabadi
approved these changes
Jan 26, 2022
davidwengier
approved these changes
Jan 26, 2022
333fred
added a commit
to YairHalberstadt/roslyn
that referenced
this pull request
Jan 28, 2022
…ess-instance-members * upstream/main: (669 commits) Fix 'hasStaticConstructor' check in MethodCompiler (dotnet#59116) Update dependencies from https://github.com/dotnet/arcade build 20220127.8 (dotnet#59134) Update StreamJsonRpc (dotnet#59073) Resources Filter cancellation exceptions in generator driver (dotnet#58843) Revert "Remove dependency on EditorFeatures from Remote.ServiceHub project (dotnet#59059)" Strings Inline Convert to switch expression Explicitly test empty string case. Fix comment Simplify test code Run all Add tests Delete test generator Add support for specifying server in tests Remove options review feedback Format document after each provider (dotnet#59091) [main] Update dependencies from dotnet/arcade (dotnet#59015) ...
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jan 28, 2022
…ceHub project (dotnet#59059)"" This reverts commit 3bbedda.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Feb 2, 2022
…ceHub project (dotnet#59059)"" This reverts commit 3bbedda.
1 task
ryzngard
added
UX Review Not Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorFeatures is client code and should not be referenced by remote services.
Moves types down from EditorFeatures to Features.