Adds the [ConditionalFact(typeof(OSVersionWin8))] attribute to several C# Compiler Unit Tests (WinRT). - #583
Closed
tannergooding wants to merge 2 commits into
Closed
Adds the [ConditionalFact(typeof(OSVersionWin8))] attribute to several C# Compiler Unit Tests (WinRT).#583tannergooding wants to merge 2 commits into
tannergooding wants to merge 2 commits into
Conversation
Pulling dotnet/roslyn to tannergooding/roslyn.
Fixes four tests in 'Roslyn.Compilers.CSharp.WinRT.UnitTests' to include the '[ConditionalFact(typeof(OSVersionWin8))]' attribute.
Contributor
|
Looks good |
Contributor
|
👍 |
tannergooding
changed the title
Member
|
I've created an alternate fix on #606 that keeps compilation but removes the execution (which was causing the test to crash). |
Member
Author
|
@agocke LGTM, I'll close this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.