Use auto prop perf#5821
Closed
mavasani wants to merge 6 commits intodotnet:masterfrom
Closed
Conversation
A couple of changes have been made here. We no longer implement this feature as a 'compilation end' analyzer. Instead, it's a 'symbol analyzer'. This should ideally mean that the results it produces are available much quicker since we don't have to wait for the compiltion analysis to end. Previously this was a compilation analyzer because we wanted to also analyze all usages to see if switching to an auto-prop would break things. Now we eagerly detect that you can convert to an auto prop, but we defer the conflict check to when you try to apply the feature (like we do for "inline temp").
1. Auto property analyzer now implements IBuiltInAnalyzer to explicitly specify which category of analyses it supports. 2. Switch method body compilers to use the origin semantic model for caching bound nodes if computing diagnostics for a semantic model.
Contributor
Author
|
/cc @CyrusNajmabadi see e285e65 for couple of changes I have tried on top of your original PR #5722 |
1) Change the auto property analyzer to register symbol actions for named types instead of properties. Otherwise, a diagnostic reported on a field from a property action is deemed as a non-local diagnostic. 2. Switch analyzer driver to now use the event from compilation event.
Member
|
This is getting stale, is this relevant anymore? |
Contributor
Author
|
Nope, closing it now. |
jjonescz
pushed a commit
to jjonescz/roslyn
that referenced
this pull request
Apr 28, 2026
* Nullable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.