Binary search for integer arrays - #542
Closed
pharring wants to merge 8 commits into
Closed
Conversation
(And I amended it after the fact)
NavigateTo doesn't support cancellation when computing the display properties so the cancellation token is getting removed rather than having to manually handling OperationCanceledException.
…d of Array.BinarySearch
…integer arrays in instead of Array.BinarySearch
Contributor
Author
|
I notice this PR has a bunch of other commits in it. Only the last two are part of this change. |
Contributor
Author
|
Sri helped me out. I'm going to re-submit this PR from a different branch. |
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Generate source for Resources.resx
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating issue #516 I discovered that we have an extension method for BinarySearch over integer arrays that is a bit faster than Array.BinarySearch. We should use that in the WithLotsOfChildren syntax lists.