Adjust doc comment for NullableWalker.VisitConversion#53429
Merged
RikkiGibson merged 2 commits intomainfrom May 18, 2021
Merged
Adjust doc comment for NullableWalker.VisitConversion#53429RikkiGibson merged 2 commits intomainfrom
RikkiGibson merged 2 commits intomainfrom
Conversation
RikkiGibson
added
Area-Compilers
Documentation
Feature - Nullable Reference Types
alrz
reviewed
May 14, 2021
| /// If <see langword="true"/>, the incoming conversion is assumed to be from binding | ||
| /// and will be re-calculated, this time considering nullability. | ||
| /// Note that the conversion calculation considers nested nullability only. | ||
| /// The caller is responsible for checking the top-level nullability of |
Member
There was a problem hiding this comment.
may I ask what do you mean by top-level nullablity? is it the outermost/initial/current state?
Member
Author
There was a problem hiding this comment.
The conversion from List<string?> to List<string> has a nested nullability violation, while the conversion from List<string>? to List<string>, has a top-level nullability violation.
Member
Author
|
Please take a look when you have the chance @cston. |
cston
approved these changes
May 17, 2021
jcouv
reviewed
May 18, 2021
ghost
modified the milestones:
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
May 20, 2021
…vice-featureslayer * upstream/main: (857 commits) Update contrib documentation (dotnet#53504) SImplify Fix out of bound crash in lsp navto. Revert changes to TypeScriptWaitContext wrappers Switch to ROSLYN_TEST_CI for CI detection SImplify Simplify LoggerTestChannel using BlockingCollection Only require telemetry validation in CI Fix out of bound crash in lsp navto. Fix locked comment Update Compiler Test Plan.md (dotnet#53420) Adjust doc comment for NullableWalker.VisitConversion (dotnet#53429) Revert "Infer delegate types with -langversion:preview only (dotnet#53241)" (dotnet#53466) Fix syntax normalizer to add space around before colon in constructor initializer (dotnet#53326) Remove unnecessary property (dotnet#53406) EnC - Tell the debugger about updated type def tokens (dotnet#53217) Revert an error Update PublishData.json Keep trailing trivia so single line if statements don't get badly formatted (dotnet#53414) Fix dead test code (dotnet#53416) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I felt like it reads better to put the description of various flags into
<param>tags. Also added a description forbool useLegacyWarnings. Not interested in renaming it at this point, but I feel like it is useful to capture somewhere what exactly it does.