Skip to content

Remove StyleCop references - #532

Merged
jaredpar merged 1 commit into
dotnet:masterfrom
jaredpar:remove-stylecop
Feb 16, 2015
Merged

Remove StyleCop references#532
jaredpar merged 1 commit into
dotnet:masterfrom
jaredpar:remove-stylecop

Conversation

@jaredpar

Copy link
Copy Markdown
Member

The code base no longer uses StyleCop. Removing lingering references to
it from the code base.

The code base no longer uses StyleCop.  Removing lingering references to
it from the code base.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a lot more ExcludeFromStyleCop directives in a bunch of other project files. Can you clean those up too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an exhaustive search for StyleCop in the GitHub code and it came up clean after this change. Going to do a corresponding one in TFS once this is submitted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like you removed them from csprojs when you did the pass to apply the style conventions. Workspaces.csproj some for example has some that were removed.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I got some during the style conversion but missed a few others.

@srivatsn

Copy link
Copy Markdown
Contributor

👍

jaredpar added a commit that referenced this pull request Feb 16, 2015
@jaredpar
jaredpar merged commit 828e0e0 into dotnet:master Feb 16, 2015
@tmat

tmat commented Feb 16, 2015

Copy link
Copy Markdown
Member

Finally :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants