Change version from rc1 to rc2. Fixes #432 - #501
Closed
agocke wants to merge 193 commits into
Closed
Conversation
AbstractSymbolCompletionProvider computes a SyntaxContext and passes that around while computing CompletionItems. Many CompletionProviders derive AbstractSymbolCompletionProvider in order to share the logic for linked files completion. This means that we'll repeatedly compute the same SyntaxContext for a given Document and position. This shows up in the 2-core typing tests. To avoid this, we'll simply cache the most recent Document/position/SyntaxContext and use it if it matches the current request.
…her. This will allow other features (like searching in Solution Explorer) to use the same searching facilities that we've just added to NavigateTo.
…ween old engine and new engine moved some more files around diagnostic incremental analyzer and added option to choose between two engines.
moved v1 engine to its own namespace and updated sources accordingly. also added BaseDiagnosticIncrementalAnalyzer which contains all methods that engine needs to implement to make all other services which consume IDiagnosticAnalyzerService to just work. probably later we will change it but for now, this should let us test v2 engine isolated without too much changes in other part of code base
put middle man in between diagnostic incremental analyzer so that two version can be changed without re-starting VS.
made diagnostic analyzer to clear existing diagnostics that belong to turned off diagnostic analyzer engine
Keep a Dictionary of Document -> Task<SyntaxContext> and a position. Every time we start computing items, check if the Documents to compute against are all keys in this dictionary. If they are, return cached tasks. Otherwise, clear the dictionary and immediately add the new set of Documents as keys. As we iterate over the set of Documents to compute completion for, we update the cache to point to the Task returned by CreateContext.
caret is at either side of the brace. The editor handles Edit.GotoBrace (ctrl + ]) and Edit.GotoBraceExtend (ctrl + shift + ]) by calling into the language service to get the location of the matching brace. In C# and VB, we always get the outer position of the brace. This was added in Vs2005 when automatic brace highlighting was added, to make the experience consistent across goto matching brace and brace highlighting. However, the vs editor expects us to return the inner position of the brace for GotoBraceExtend. This change fixes up GotoBraceExtend, while retaining consistent experience between all the three features : BraceHighlighting, GotoBrace and GotoBraceExtend.
we can end up load analyzers for a language that does not even exist in current solution.
VB CodeModel now returns proper EnvDTE80.vsCMFunction2 values for AddHandler, RemoveHandler and RaiseEvent accessors.
This commit changes 'lock (this)' usage into a lock on a private object which only instance is knowledgeable about.
VB CodeModel now returns vsCMFunctionDestructor for Overrides Finalize() members
Member
|
👍 |
some code clean up based on PR feedback
preserve encoding over temporary storage
…ions Reduce C# emit test allocations
Member
Author
|
retest this please |
Fix up some places where: - Char literals were used in string concatenation, resulting in boxing and string allocations that could be avoided if a string literal were used instead - Value types were used in string concatenation, resulting in unnecessary boxing allocations
These were mistakenly omitted when these files were originally pushed to GitHub.
This type was mistakenly not formatted when the code was added to GitHub.
Minor tweaks to avoid some allocations
Avoid unnecessary boxing with String.Concat
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Add test projects for MSTest
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.