Completion API Options #4933
Merged
Completion API Options #4933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, the IsDebugger and IsImmediateWindow properties have been removed from CompletionTriggerInfo. Any code that was checking these properties now checks for options that are set by the Controller in debugger scenarios.
| } | ||
| else | ||
| { | ||
| return null; |
There was a problem hiding this comment.
Is there a reason we return null here instead of an empty CompletionList value (if that's even possible)?
There was a problem hiding this comment.
Good suggestion. I'll return an empty CompletionList here.
There was a problem hiding this comment.
Or rather an empty Task<CompletionList>
|
Overall I love this. My feedback is just nits. |
DustinCampbell
force-pushed
the
completion-options
branch
from
13465d1 to
2085591
Compare
|
retest this please |
| if (options.GetOption(CompletionOptions.AlwaysShowBuilder)) | ||
| { | ||
| var text = await document.GetTextAsync(cancellationToken).ConfigureAwait(false); | ||
| builder = this.CreateEmptyBuilder(text, position); |
There was a problem hiding this comment.
Nit: Should you show the specific builder with it's text if there is one, even if the option is true?
There was a problem hiding this comment.
Yes, that seems a good idea. This is consistent with our existing behavior, but that's better behavior. 😄 I'll file a bug.
|
Late to the party, but this looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #3538.
This change threads an OptionSet through the completion API and removes the smelly "IsDebugger" and "IsImmediateWindow" properties from CompletionTriggerInfo
Reviewers: @rchande, @dpoeschl, @CyrusNajmabadi, @balajikris, @brettfo, @Pilchie, @jasonmalinowski, @davkean, @jmarolf