Unify VS Setup - #484
Merged
Merged
Conversation
|
Hi @jasonmalinowski, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
Member
|
LGTM |
|
@jasonmalinowski, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Contributor
|
I updated the Commands.vsct file this morning, so you may want to pull in those changes before you move it to open. |
This change moves the contents of VisualStudioSetup into the open, merging with (and consuming) VisualStudioComponents. The Components/ Setup split originally existed as a way to allow multiple Roslyn-using components to have a single source of truth of the MEF exports. This meant you could have either the interactive window, language services, or both installed and everything worked. This was important when we were atop Visual Studio 2013, but now that we're integrated it's buying us nothing. The VSIX ID from VisualStudioComponents is preserved so that way any extensions that declared a dependency on it will still work.
jasonmalinowski
force-pushed
the
unify-vs-setup
branch
from
February 13, 2015 19:03
7c22a5b to
da85b6e
Compare
Member
Author
|
@tmeschter Can you verify I've consumed the update? |
Contributor
|
Looks like it's all up to date. |
Member
|
LGTM |
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Include framework references except for package based frameworks
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change to move some of the stuff in our language service integration to GitHub.