add bare minimum implementation of diagnostic analyzer that uses compiler analyzer driver - #477
Merged
Merged
Conversation
fixed reporting issue and de-duplication issues.
Contributor
Author
|
@mavasani @srivatsn @shyamnamboodiripad can you guys take a look? |
fixed typo and removed stale comments
…manager and what must be cached by caller. GetXXX method is used for information that manager can cache or already cached. CreateXXX method is used for information that manager can't cache.
Contributor
There was a problem hiding this comment.
Should this be instead renamed to "GetDiagnosticAnalyzers" as it isn't creating them for each invocation?
Contributor
Author
There was a problem hiding this comment.
not sure what you meant. GetProjectDiagnosticsAsync generate project wide diagnostics.
Contributor
|
👍 Great! |
Contributor
|
👍 |
heejaechang
pushed a commit
that referenced
this pull request
Feb 13, 2015
add bare minimum implementation of diagnostic analyzer that uses compiler analyzer driver
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Support fixing a single diagnostic
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added bare minimum implementation of diagnostic analyzer that uses compiler analyzer driver.
literally it is bare minimum implementation. so there is no state or anything to boost performance. it always do everything from scratch.
but, it proves that as long as given interface is implemented, all existing IDE features will continue working. also, since it generates compilation end action diagnostics, those will just work as well. this can be used as a prototype to see what experience will look like once we actually support that scenario.