Dont format while typing inside Nonuser code - #454
Conversation
There was a problem hiding this comment.
Is this a typing error?
Istyped -> IsTyped
There was a problem hiding this comment.
Yes, it is a typing error. Will fix it. Thanks.
|
so I searched code base and found the one we are using. we have bunch of code that checks context. can you use this rather than creating your own check? I thought auto formatter already used this before. not sure when that went away? |
|
@basoundr do we check for if def'd out regions which is also considered as commented out code.. If so, we may need to add tests for those as well. |
|
@basoundr @balajikris the link I linked above should handle those cases as well. |
|
@balajikris @heejaechang I was looking into the API that you mentioned. It seems that it satisfies the cases I had tested. I will just need to verify if it doesn't cover cases that we don't want to. Once I get it verified, I will update the PR. Thanks for letting me know about the PR. |
|
I have some mistakes with my commits. Will rectify those and reopen the PR |
Handle reordering of expected arguments
Fix #449 : Don't format inside Comments
Dont format while typing '{', ')',inside comments(Both Regular and Doc Comments)