Progression should properly descend into types for IntelliTrace MVC queries - #421
Merged
Merged
Conversation
Member
Author
|
@jasonmalinowski can you take a look? |
Member
There was a problem hiding this comment.
Rather than all of this, it still seems easier if we just test the BeginGetGraphData method directly. If you extract out the logic of context -> IEnumerable<GraphQueries> directly to a simple static method, we just write a very simple test that asserts that given the graph query in question results in determining we need a Contains query. Much smaller and more direct.
…ntains]} This will allow IntelliTrace files generated from MVC projects to navigate properly.
brettfo
force-pushed
the
graph-provider-contains
branch
from
February 12, 2015 19:02
e060c13 to
62cdaa7
Compare
Member
Author
|
@Jenkins test this please |
Member
Author
|
retest this please |
Member
|
👍 |
Member
|
|
brettfo
added a commit
that referenced
this pull request
Feb 12, 2015
Progression should properly descend into types for IntelliTrace MVC queries
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Automatically include all compiler diagnostics with IDs that match a provided code fix
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When BeginGetGraphData() (in GraphProvider.cs) was migrated from the old code, a query type of the format {Direction=Target, LinkCategories=[Contains]} was missed that IntelliTrace produced when it wanted us to descend into types.