Introduce a DiscardSyntaxClassifier - #40396

Merged

JoeRobich merged 25 commits into

dotnet:masterfrom

lameox:highlight-out-_

Jan 27, 2020

Commits on Dec 14, 2019

Introduce a DiscardParameterHighlighter which fixes #39768
lameox
committed
543803d

Commits on Dec 15, 2019

Commits on Dec 16, 2019

Fixed return types in test cases.
lameox
committed
d23ec64
Renamed the highlighter and test to DiscardArgumentHighlighter instead of DiscardParameterHighlighter
lameox
committed
8786800
Additional test for a @_ that is already in scope and used as the out argument
lameox
committed
3552b39

Commits on Dec 17, 2019

Commits on Dec 20, 2019

Extended the DiscardSyntaxClassifier so it covers the other discard patterns that might come up.
lameox
committed
d366c3c

Commits on Jan 2, 2020

switched to the more general base class (AbstractSyntaxClassifier)
lameox
committed
8e93d34

Commits on Jan 8, 2020

removed he special case for a single underscore parameter that isn't used
lameox
committed
bf47f1b
Added an aditional test for lambdas with inferred type
lameox
committed
74d8060
Refactoring of the DiscardSyntaxClassifier:
lameox
committed
3a493ea
avoid binding all identifier names
lameox
committed
8b77049
inline ClassifySymbol
lameox
committed
16ba315
throw unreachable exception instead of asserting
lameox
committed
d498eb8
simplified parameter handling. Inlined it as well.
lameox
committed
25900e9
added check for identifier text on parameter, moved the checks into the pattern match
lameox
committed
3bed577
fixed possible NPE
lameox
committed
7bdbfb9

Commits on Jan 15, 2020

Commits on Jan 16, 2020