-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Add skipped test for https://github.com/dotnet/roslyn/issues/320 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
160 changes: 160 additions & 0 deletions
160
src/EditorFeatures/CSharpTest/Diagnostics/FixAllProvider/BatchFixerTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using System.Collections.Immutable; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.CodeAnalysis.CodeActions; | ||
| using Microsoft.CodeAnalysis.CodeFixes; | ||
| using Microsoft.CodeAnalysis.CSharp; | ||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Roslyn.Test.Utilities; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Diagnostics.SimplifyTypeNames | ||
| { | ||
| public partial class BatchFixerTests : AbstractCSharpDiagnosticProviderBasedUserDiagnosticTest | ||
| { | ||
| internal override Tuple<DiagnosticAnalyzer, CodeFixProvider> CreateDiagnosticProviderAndFixer(Workspace workspace) | ||
| { | ||
| return Tuple.Create<DiagnosticAnalyzer, CodeFixProvider>(new QualifyWithThisAnalyzer(), new QualifyWithThisFixer()); | ||
| } | ||
|
|
||
| [DiagnosticAnalyzer(LanguageNames.CSharp)] | ||
| private class QualifyWithThisAnalyzer : DiagnosticAnalyzer | ||
| { | ||
| public static readonly DiagnosticDescriptor Descriptor = new TriggerDiagnosticDescriptor("QualifyWithThis"); | ||
|
|
||
| public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics | ||
| { | ||
| get | ||
| { | ||
| return ImmutableArray.Create(Descriptor); | ||
| } | ||
| } | ||
|
|
||
| public override void Initialize(AnalysisContext context) | ||
| { | ||
| context.RegisterSyntaxNodeAction<SyntaxKind>(AnalyzeNode, SyntaxKind.IdentifierName); | ||
| } | ||
|
|
||
| private static void AnalyzeNode(SyntaxNodeAnalysisContext context) | ||
| { | ||
| var node = context.Node as SimpleNameSyntax; | ||
| if (node != null) | ||
| { | ||
| var symbol = context.SemanticModel.GetSymbolInfo(node).Symbol; | ||
| if (symbol != null && symbol.Kind == SymbolKind.Field) | ||
| { | ||
| var diagnostic = Diagnostic.Create(Descriptor, node.GetLocation()); | ||
| context.ReportDiagnostic(diagnostic); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private class QualifyWithThisFixer : CodeFixProvider | ||
| { | ||
| public override ImmutableArray<string> FixableDiagnosticIds | ||
| { | ||
| get | ||
| { | ||
| return ImmutableArray.Create(QualifyWithThisAnalyzer.Descriptor.Id); | ||
| } | ||
| } | ||
|
|
||
| public async override Task RegisterCodeFixesAsync(CodeFixContext context) | ||
| { | ||
| var root = await context.Document.GetSyntaxRootAsync(context.CancellationToken).ConfigureAwait(false); | ||
| var node = root.FindNode(context.Span, getInnermostNodeForTie: true) as SimpleNameSyntax; | ||
| if (node != null) | ||
| { | ||
| var leadingTrivia = node.GetLeadingTrivia(); | ||
| var newNode = SyntaxFactory.MemberAccessExpression( | ||
| SyntaxKind.SimpleMemberAccessExpression, | ||
| SyntaxFactory.ThisExpression(), | ||
| node.WithoutLeadingTrivia()) | ||
| .WithLeadingTrivia(leadingTrivia); | ||
|
|
||
| var newRoot = root.ReplaceNode(node, newNode); | ||
| var newDocument = context.Document.WithSyntaxRoot(newRoot); | ||
|
|
||
| // Disable RS0005 as this is test code and we don't need telemtry for created code action. | ||
| #pragma warning disable RS0005 // Do not use generic CodeAction.Create to create CodeAction | ||
| var fix = CodeAction.Create("QualifyWithThisFix", _ => Task.FromResult(newDocument)); | ||
| #pragma warning restore RS0005 // Do not use generic CodeAction.Create to create CodeAction | ||
|
|
||
| context.RegisterCodeFix(fix, context.Diagnostics); | ||
| } | ||
| } | ||
|
|
||
| public override FixAllProvider GetFixAllProvider() | ||
| { | ||
| return WellKnownFixAllProviders.BatchFixer; | ||
| } | ||
| } | ||
|
|
||
| #region "Fix all occurrences tests" | ||
|
|
||
| [Fact(Skip = "https://github.com/dotnet/roslyn/issues/320")] | ||
| [Trait(Traits.Feature, Traits.Features.CodeActionsFixAllOccurrences)] | ||
| public void TestFixAllInDocument_QualifyWithThis() | ||
| { | ||
| var input = @" | ||
| <Workspace> | ||
| <Project Language=""C#"" AssemblyName=""Assembly1"" CommonReferences=""true""> | ||
| <Document> | ||
| class C | ||
| { | ||
| int Sign; | ||
| void F() | ||
| { | ||
| string x = @""namespace Namespace | ||
| { | ||
| class Type | ||
| { | ||
| void Foo() | ||
| { | ||
| int x = 1 "" + {|FixAllInDocument:Sign|} + @"" "" + Sign + @""3; | ||
| } | ||
| } | ||
| } | ||
| ""; | ||
| } | ||
| } | ||
| </Document> | ||
| </Project> | ||
| </Workspace>"; | ||
|
|
||
| var expected = @" | ||
| <Workspace> | ||
| <Project Language=""C#"" AssemblyName=""Assembly1"" CommonReferences=""true""> | ||
| <Document> | ||
| class C | ||
| { | ||
| int Sign; | ||
| void F() | ||
| { | ||
| string x = @""namespace Namespace | ||
| { | ||
| class Type | ||
| { | ||
| void Foo() | ||
| { | ||
| int x = 1 "" + this.Sign + @"" "" + this.Sign + @""3; | ||
| } | ||
| } | ||
| } | ||
| ""; | ||
| } | ||
| } | ||
| </Document> | ||
| </Project> | ||
| </Workspace>"; | ||
|
|
||
| Test(input, expected, isLine: false, compareTokens: false); | ||
| } | ||
|
|
||
| #endregion | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a justification on why we are doing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.