Add support for custom unnecessary locations on a diagnostic.#39649
Merged
dibarbet merged 6 commits intodotnet:masterfrom Jan 2, 2020
Merged
Add support for custom unnecessary locations on a diagnostic.#39649dibarbet merged 6 commits intodotnet:masterfrom
dibarbet merged 6 commits intodotnet:masterfrom
Conversation
Contributor
|
LMK when you'd like a review. thanks! |
Member
Author
I think you should be able to take a look. Was thinking about just encoding the locations into the property bag, but I think this ends up being easier since I get the conversion to |
src/EditorFeatures/Core/Implementation/Diagnostics/DiagnosticsClassificationTaggerProvider.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 8, 2019
src/EditorFeatures/Core/Implementation/Diagnostics/DiagnosticsClassificationTaggerProvider.cs
Show resolved
Hide resolved
mavasani
reviewed
Nov 8, 2019
src/EditorFeatures/Core/Implementation/Diagnostics/DiagnosticsClassificationTaggerProvider.cs
Show resolved
Hide resolved
mavasani
reviewed
Nov 8, 2019
src/EditorFeatures/Core/Implementation/Diagnostics/DiagnosticsClassificationTaggerProvider.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Nov 8, 2019
mavasani
approved these changes
Nov 8, 2019
Contributor
mavasani
left a comment
mavasani
left a comment
There was a problem hiding this comment.
Overall LGTM. Just have some suggestions around adding more defensive code and adding an example to doc comments. Lets hope we can use the API you added to get rid of the remaining fake fading diagnostics in follow-up PR(s).
dibarbet
force-pushed
the
dupe_error_list
branch
from
389c190 to
09bd524
Compare
mavasani
approved these changes
Jan 2, 2020
dibarbet
force-pushed
the
dupe_error_list
branch
from
db7f64f to
2501c21
Compare
This was referenced Jan 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.