Features/lsp support liveshare2 #35214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
force-pushed
the
features/lspSupport_liveshare2
branch
from
67fb44c to
d252a1a
Compare
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/CustomProtocol/RoslynCompletionItem.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Extensions/ProtocolConversions.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
| /// Handles the get code actions command. | ||
| /// </summary> | ||
| [Shared] | ||
| [ExportLspMethod(LSP.Methods.TextDocumentCodeActionName)] |
There was a problem hiding this comment.
name for export and interface, we probably need to change later after design meeting.
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandlerBase.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandlerBase.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/PreviewCodeActionsHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/CodeActions/PreviewCodeActionsHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Completion/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Completion/CompletionResolveHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
| var description = await completionService.GetDescriptionAsync(document, selectedItem, cancellationToken).ConfigureAwait(false); | ||
|
|
||
| LSP.CompletionItem resolvedCompletionItem; | ||
| if (clientCapabilities?.HasVisualStudioLspCapability() == true) |
There was a problem hiding this comment.
so, this without VS extension (I think we should rename it LSP.Extension not VS Extension) we return RoslynCompletionItem? not regular LSP completion Item?
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Completion/CompletionResolveHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Completion/CompletionResolveHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Definitions/GoToDefinitionHandlerBase.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Definitions/GoToDefinitionHandlerBase.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/FoldingRanges/FoldingRangesHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Formatting/FormatDocumentOnTypeHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Formatting/FormatDocumentOnTypeHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Formatting/FormatDocumentOnTypeHandler.cs
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Formatting/FormatDocumentRangeHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Formatting/FormatDocumentRangeHandler.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/IRequestHandlerMetadata.cs
Outdated
Show resolved
Hide resolved
heejaechang
reviewed
Apr 29, 2019
heejaechang
reviewed
Apr 29, 2019
src/Features/LanguageServer/Protocol/Handler/Initialize/InitializeHandler.cs
Outdated
Show resolved
Hide resolved
JoeRobich
force-pushed
the
features/lspSupport
branch
from
e561eb8 to
0129409
Compare
dibarbet
force-pushed
the
features/lspSupport_liveshare2
branch
from
3a3460e to
e42a4b0
Compare
… liveshare handlers.
… item in the client.
…th dynamic usage on internal types.
dibarbet
force-pushed
the
features/lspSupport_liveshare2
branch
from
e42a4b0 to
908819f
Compare
heejaechang
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies and creates liveshare LSP handlers so that they can be exported from roslyn instead of from liveshare.
The implementation of all the handlers is copied directly from liveshare. For now, I'll be leaving that as-is and later will be going 1 by 1 to clean them all up once liveshare is working from roslyn. Mainly would like feedback on the structure (handlers, location of classes, etc)
Where possible, I've moved the implementation into the features layer. However, some have dependencies on the UI, so I've kept those in the VS language services layer until we can remove those dependencies.
TODO - more testsTODO - get actual release build of MS.VS.LanguageServer.Protocol (so CI passes)TODO - Wait for fixed liveshare nuget pkg