Updates link to .NET SDK in an error message #24694
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hard link points to a specific version of .NET SDK installer which causes user's machine to end up in a bad state: see [dotnet/cli/issues/8531] and [this](dotnet/designs#29 (comment)) This PR changes the link to the general download page, where user will get a correct and supported version of the SDK
jaredpar
requested changes
Feb 9, 2018
Member
jaredpar
left a comment
jaredpar
left a comment
There was a problem hiding this comment.
We have an issue open to update our CLI version. Until then we need to keep pointing to this build as it has features needed to build our repo.
sharwell
suggested changes
Feb 14, 2018
Contributor
sharwell
left a comment
sharwell
left a comment
There was a problem hiding this comment.
This error message was the only way we were able to figure out how to unblock testing of #24673. Until the specific version requirement is removed, this error message needs to always point at the specific installer required for building this repository.
Contributor
|
@jaredpar I wanted to close this in favor of the issue you mentioned, but was unable to find it. |
Member
|
Here is the tracking issue #24591 I have to wait for a broader announcement to come through before I can fix that issue. Once it's out though I will pretty quickly get it fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hard link in the error message points to a specific version of .NET SDK installer which causes user's machine to end up in a bad state: see dotnet/cli/issues/8531 and this
This PR changes the link to the general download page, where user may get a correct and supported version of the SDK
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.