Produce 'invisible' squiggles for 'Remove Unnecessary Usings' and 'Simpl... - #1243
Conversation
|
@srivatsn @heejaechang @mavasani @tmeschter @jmarolf - could you please take a look? FYI @balajikris |
|
@dotnet-bot test this please |
There was a problem hiding this comment.
It would be nice to keep the descriptor here so that both of the descriptors are together instead of being spread across three files. Instead of the abstract GetClassificationIdDescriptor, you could simply have an abstract GetMessage(). That way if we make changes to the descriptor we can make it in one place.
There was a problem hiding this comment.
Sure will change that.
|
Jenkins is failing because PredefinedErrorTypeNames.Suggestion is a new value that's not in the CTP6 build that Jenkins uses. I think we should have a conditional constant in RoslynLight.sln and then ifdef out this statement when that constant is not defined. |
|
👍 |
3e17386 to
8695b16
Compare
|
Introducing solution level conditional constant in a way that works smoothly for both command line and VS builds of this solution is complicated. For now, I've removed the projects that depend on the new API from RoslynLight.sln to fix Jenkins. I've addressed the remaining pieces of feedback above. Waiting for Jenkins build to succeed. I will go ahead and merge this once that succeeds. |
|
@dotnet-bot test this please |
There was a problem hiding this comment.
You could write analyzerMap?.Count > 0 and flip then/else branches.
8695b16 to
540f788
Compare
…mplify Type Name'. Produce invisible / suggestion squiggles (which will in turn display Quick Info on mouse hover) for the hidden diagnostics that we report for 'Remove Unnecessary Usings' and 'Simplify Type Name'. The presence of Quick Info pane for such squiggles allows allows platform to display Light Bulb for the corresponding fixes. Per their current design platform can only display light bulb if Quick Info pane is present.
540f788 to
7d4ed23
Compare
Produce 'invisible' squiggles for 'Remove Unnecessary Usings' and 'Simpl...
5 participants
...ify Type Name'.
Produce invisible / suggestion squiggles (which will in turn display Quick Info on mouse hover) for the hidden diagnostics that we report for 'Remove Unnecessary Usings' and 'Simplify Type Name'. The presence of Quick Info pane for such squiggles allows allows platform to display Light Bulb for the corresponding fixes. Per their current design platform can only display light bulb if Quick Info pane is present.
Here's some screenshots that show how the quick info + light bulb will look -
If we have multiple issues on the line -
