Dont disturb whitespace preceding comments - #1166
Conversation
Fix dotnet#1151 : Dont disturb the whitespaces preceding the comments which are also not part of indentation to be converted to tabs if 'Keep Tabs' option is set.
There was a problem hiding this comment.
With this change the (completely untested 😦) UseTabOnlyForIndentation option has no effect anymore. The idea of that option is to use Tabs for the base indentation of the statement, and then spaces for alignment of consecutive lines after that initial set of tabs.
Perhaps we should either:
- Remove the option, since it's untested and not exposed through the UI.
- Add it back, put some tests in place, and use a different method to calculate alignment spaces and the spaces between tokens.
There was a problem hiding this comment.
Ooh, for what it's worth, that option sounds awesome. But if I had to choose, I'd rather have #1151 fixed than the option (for now).
There was a problem hiding this comment.
Yes, I have removed the option. Given that we dont have any test for this option and no more using this option in the code, it is ideal to have this option removed.
Issue #1176 has been opened to track the addition of the option with precise intent and testcases
Remove UseTabOnlyForIndentation since this is a public option & there are no testcases for this option. With the changes the option is no longer used making it obsolete. Fix the broken testcase which was asserting the undesired behavior
5474397 to
f879029
Compare
|
@Pilchie @heejaechang Please take a look at the final changes. This is a RC bug that needs to be fixed by tomorrow. Other potential reviewers : @jasonmalinowski @dpoeschl @rchande @balajikris @brettfo |
|
👍 |
Dont disturb whitespace preceding comments
Fix compliation errors in Testing README sample custom verifier
5 participants
Fix #1151 : Dont disturb the whitespaces preceding the comments which
are also not part of indentation to be converted to tabs if 'Keep Tabs'
option is set.