Run code formatter on VB compiler source code

[jaredpar]

This is the initial run of the code formatter on the VB compiler source code. Further runs I'll expand on this to include all VB code in a future run.

[jaredpar]

FYI @dpoeschl

[gafter]

Paging @AlekseyTs as I know you've had some strong opinions about some of these changes in the past.

[AdamSpeight2008]

@AlekseyTs isn't going to be happy, having the scroll horizontally to see the changes.
I think it also changes the scoping of some the methods. From not having an explicitly declared one (so defaults I think Private?) to having an an explicitly declared one.

[AdamSpeight2008]

Please also consider using a 2 space indentation, instead of 4. It reduce the sideways scrolling on diffs.
My Fork's scanner folder uses. (Note: I also turn of the pretty-printer)

It's also going cause a lot of merge conflicts, that wouldn't to deal with. I think it is likely afterwards that most would re-clone the repo rather than deal with them.

[AlekseyTs]

It feels like the original indentation should be preserved.

[AlekseyTs]

LGTM with exception of several unexpected indentation changes (each has a separate comment).

[jaredpar]

@AlekseyTs thanks for taking the time to review that ... giant change ;)

CC @basoundr, @dpoeschl for the indentation issues. I agree that a lot of those look like bugs, in particular the comment shifting. I'm going to manually undo these before I commit but it's important that we fix the Formatter.FormatDocumentAsync code as well. Is there a bug tracking this already?

[basoundr]

@jaredpar I remember we ran into some formatting issue sometime back when you ran Formatter.FormatDocumentAsync (couple of weeks, maybe?). I dont see any issue that tracks that. We must definitely track this issue.

I can create one and will reference this PR in the bug, if you dont remember filing an issue already.

[jaredpar]

@basoundr I'll get a bug filed as a part of checking this in.

[basoundr]

@jaredpar Thanks :)

[jaredpar]

Formatting issue is #1177