Ensure AnalyzerDriver completes during Compilation - #1134
Merged
Conversation
Today the AnalyzerDriver is only guaranteed to be completed after a Compilation if the compilation made it to the Emit phase. If the compiler exited early, say to method body binding failures, the compiler would not produce all of the compilation events and hence the analyzer driver would be left forever waiting for them to complete.
Member
Author
|
CC @VSadov , @AlekseyTs, @VladimirReshetnikov , @agocke |
Member
There was a problem hiding this comment.
This looks good but it occurs to me... perhaps this method is getting too long?
Member
Author
There was a problem hiding this comment.
I agree. It's gotten a bit out of hand and needs to be broken up. Will take a shot at it.
Member
|
👍 |
Member
|
LGTM |
jaredpar
added a commit
that referenced
this pull request
Mar 11, 2015
Ensure AnalyzerDriver completes during Compilation
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the AnalyzerDriver is only guaranteed to be completed after a
Compilation if the compilation made it to the Emit phase. If the
compiler exited early, say to method body binding failures, the compiler
would not produce all of the compilation events and hence the analyzer
driver would be left forever waiting for them to complete.
closes #1086