Skip to content

Rename "Src" to "src", so all the files line up. - #1120

Merged
jaredpar merged 1 commit into
masterfrom
unknown repository
Mar 9, 2015
Merged

Rename "Src" to "src", so all the files line up.#1120
jaredpar merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 7, 2015

Copy link
Copy Markdown

If you look at the git root directory for this project, you'll see two "src" folders, one with an upper case "S", one with a lower case "s".

This PR resolves that issue by renaming the files to "src", which follows the established convention with the "build" and "docs" folders.

For some reason while making this PR I had some issues with src\Compilers\VisualBasic\Test\Emit\Resource.Designer.vb, the file would not reset when explicitly told to.. Given that the file system records were a little off I wouldn't be surprised if this file also has some issues.

@dnfclas

dnfclas commented Mar 7, 2015

Copy link
Copy Markdown

Hi @beannaich, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas

dnfclas commented Mar 7, 2015

Copy link
Copy Markdown

@beannaich, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@jaredpar

jaredpar commented Mar 8, 2015

Copy link
Copy Markdown
Member

@dotnet-bot test this please

@jaredpar

jaredpar commented Mar 8, 2015

Copy link
Copy Markdown
Member

@beannaich thanks for doing this. Have no idea why Jenkins failed that job as it listed everything as passing. I kicked off another Jenkins build to see if it will unstick itself.

@ghost

ghost commented Mar 8, 2015

Copy link
Copy Markdown
Author

@jaredpar No problem, was an easy enough fix to make. I just noticed it when I went to the roslyn page and thought "Two src folders..?"

As I noted in the PR description, there was some strange behavior with one of the VB resources designer files.

@stephentoub

Copy link
Copy Markdown
Member

@dotnet-bot test this please

@jaredpar

jaredpar commented Mar 9, 2015

Copy link
Copy Markdown
Member

@stephentoub hold off on merging this. Have a larger change I'm trying to get in. I'll merge this once I get that done (ETA 10 min)

@stephentoub

Copy link
Copy Markdown
Member

@jaredpar, thanks, wasn't going to merge... just went through and kicked off rebuilds for all of the PR CI builds that failed due to that script error you just fixed.

@jaredpar

jaredpar commented Mar 9, 2015

Copy link
Copy Markdown
Member

@stephentoub ah okay. Thanks for doing that ;)

jaredpar added a commit that referenced this pull request Mar 9, 2015
Rename "Src" to "src", so all the files line up.
@jaredpar
jaredpar merged commit 6134288 into dotnet:master Mar 9, 2015
@ghost

ghost commented Mar 9, 2015

Copy link
Copy Markdown
Author

I could have rebased this before merging :)

@ghost
ghost deleted the fix-src-folders branch March 9, 2015 16:24
@davkean davkean added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 16, 2015
jjonescz pushed a commit to jjonescz/roslyn that referenced this pull request Apr 28, 2026
…3.1-to-master

[automated] Merge branch 'release/3.1' => 'master'
dibarbet pushed a commit that referenced this pull request Aug 18, 2026
Create export provider asynchronously
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants