Conversation
|
Hi @beannaich, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@beannaich, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@dotnet-bot test this please |
|
@beannaich thanks for doing this. Have no idea why Jenkins failed that job as it listed everything as passing. I kicked off another Jenkins build to see if it will unstick itself. |
|
@jaredpar No problem, was an easy enough fix to make. I just noticed it when I went to the roslyn page and thought "Two src folders..?" As I noted in the PR description, there was some strange behavior with one of the VB resources designer files. |
|
@dotnet-bot test this please |
|
@stephentoub hold off on merging this. Have a larger change I'm trying to get in. I'll merge this once I get that done (ETA 10 min) |
|
@jaredpar, thanks, wasn't going to merge... just went through and kicked off rebuilds for all of the PR CI builds that failed due to that script error you just fixed. |
|
@stephentoub ah okay. Thanks for doing that ;) |
Rename "Src" to "src", so all the files line up.
|
I could have rebased this before merging :) |
…3.1-to-master [automated] Merge branch 'release/3.1' => 'master'
Create export provider asynchronously
If you look at the git root directory for this project, you'll see two "src" folders, one with an upper case "S", one with a lower case "s".
This PR resolves that issue by renaming the files to "src", which follows the established convention with the "build" and "docs" folders.
For some reason while making this PR I had some issues with
src\Compilers\VisualBasic\Test\Emit\Resource.Designer.vb, the file would not reset when explicitly told to.. Given that the file system records were a little off I wouldn't be surprised if this file also has some issues.