Enable hosts to compile strong-named assemblies on all platforms by supp... - #1071
Conversation
|
/cc @AnthonyDGreen @theoy -- this change updates public API surface. |
There was a problem hiding this comment.
Any particular reason you swapped this around? This is just going to confuse the translators.
There was a problem hiding this comment.
@gafter Yes, to match C# order -- I need to create the diagnostic in shared code and C# had a different order.
|
Other than the strange indentation issue, looks good to me. |
…upplying public key via compilation options and also enable OSS signing with such key
|
@gafter I fixed the indentation. Not sure why the VB formatter decided to insert it. |
Enable hosts to compile strong-named assemblies on all platforms by supp...
|
Should we abstract all of the Crypto fields into a separate type? It seems fragile to have properties where the doc (paraphrased) says:
Feel like this will be much easier to manage if it's a separate type which encapsulates the various states the data can be in. |
|
@davidfowl Sounds like a bug in JSON serializer. |
|
@jaredpar I don't think that's really necessary. It's trivial to validate the requirement and report diagnostics, which is what we are doing. |
|
@davidfowl I guess that it can be serialized if the CryptoPublicKey is specified? |
Add MarkupOptions.TreatPositionIndicatorsAsCode
...lying public key via compilation options and also enable OSS signing with such key
Fixes #567