Skip to content

Enable hosts to compile strong-named assemblies on all platforms by supp... - #1071

Merged
tmat merged 2 commits into
dotnet:masterfrom
tmat:CryptoPublicKey
Mar 6, 2015
Merged

Enable hosts to compile strong-named assemblies on all platforms by supp...#1071
tmat merged 2 commits into
dotnet:masterfrom
tmat:CryptoPublicKey

Conversation

@tmat

@tmat tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member

...lying public key via compilation options and also enable OSS signing with such key

Fixes #567

@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

@tmat tmat added Concept-API This issue involves adding, removing, clarification, or modification of an API. Area-Compilers Feature Request Concept-CoreCLR The issue involves operations and features specific to CoreCLR work. labels Mar 6, 2015
@tmat tmat added this to the 1.0-rc2 milestone Mar 6, 2015
@tmat tmat self-assigned this Mar 6, 2015
@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

/cc @jasonmalinowski @davidfowl

@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

/cc @AnthonyDGreen @theoy -- this change updates public API surface.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason you swapped this around? This is just going to confuse the translators.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gafter Yes, to match C# order -- I need to create the diagnostic in shared code and C# had a different order.

@gafter

gafter commented Mar 6, 2015

Copy link
Copy Markdown
Member

Other than the strange indentation issue, looks good to me.

…upplying public key via compilation options and also enable OSS signing with such key
@tmat
tmat force-pushed the CryptoPublicKey branch from b016f1d to f591db0 Compare March 6, 2015 01:44
@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

@gafter I fixed the indentation. Not sure why the VB formatter decided to insert it.

tmat added a commit that referenced this pull request Mar 6, 2015
Enable hosts to compile strong-named assemblies on all platforms by supp...
@tmat
tmat merged commit c7ca32f into dotnet:master Mar 6, 2015
@tmat
tmat deleted the CryptoPublicKey branch March 6, 2015 03:17
@jaredpar

jaredpar commented Mar 6, 2015

Copy link
Copy Markdown
Member

Should we abstract all of the Crypto fields into a separate type? It seems fragile to have properties where the doc (paraphrased) says:

if this is non-null then this other property must be null

Feel like this will be much easier to manage if it's a separate type which encapsulates the various states the data can be in.

@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

@davidfowl Sounds like a bug in JSON serializer.

@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

@jaredpar I don't think that's really necessary. It's trivial to validate the requirement and report diagnostics, which is what we are doing.

@tmat

tmat commented Mar 6, 2015

Copy link
Copy Markdown
Member Author

@davidfowl I guess that it can be serialized if the CryptoPublicKey is specified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Concept-API This issue involves adding, removing, clarification, or modification of an API. Concept-CoreCLR The issue involves operations and features specific to CoreCLR work. Feature Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to provide a CryptoKeyFile as a byte[]

5 participants