Delete the public TriggerDiagnosticDescriptor type. - #1065
Merged
shyamnamboodiripad merged 1 commit intoMar 6, 2015
Merged
Conversation
Contributor
Author
|
@tmeschter @mavasani @heejaechang @srivatsn could you please take a look? |
Contributor
There was a problem hiding this comment.
Maybe add a comment about the reasons for message=null and the notconfigurable tag?
Contributor
Author
There was a problem hiding this comment.
Sure I'll add a comment for this.
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Doc comments here would be helpful.
Contributor
Author
There was a problem hiding this comment.
I didn't add doc comments since this is for tests only :) But will add.
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
And seal its base type DiagnosticDescriptor. (Fixes dotnet#789)
shyamnamboodiripad
force-pushed
the
DeleteTriggerDiagnosticDescriptor
branch
from
March 6, 2015 08:41
d65864e to
f1045fd
Compare
Contributor
|
👍 |
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Add LightupHelpers.CreatePropertyAccessor
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And seal its base type DiagnosticDescriptor.
(Fixes #789)