Remove Logger and RoslynCompilerEventSource - #1057
Conversation
|
@agocke @heejaechang Please review. This should be simple, it's just deleting code :-) |
|
LGTM, thanks for taking this one! |
|
BTW, this change is way easier to review if you add &w=1 to your URL -- it'll hide the whitespace changes. |
|
adding @shyamnamboodiripad |
|
looks good to me. ... so, I guess compiler doesnt need etw for perf investigation at all? I find it quite useful when trying to improve perf of feature. I used it to improve FAR, HR, formatting engine, tagger and more. basically it let me see sequence of all events and time each pipe line took. |
|
LGTM |
Remove Logger and RoslynCompilerEventSource
|
LGTM. Its sad that we had to remove the logger code entirely - but I guess we can always bring this back if we need to. |
|
@shyamnamboodiripad @heejaechang This is why we have version control :) All this code is a revert away (if we really want it). |
|
👍 |
Support testing with newer versions of vs-mef
Remove the Logger and ETW event source from the compiler layer. Addresses #1007