Fix ContainedLanguage support for Workflow v1 XOML files - #1021
Merged
DustinCampbell merged 2 commits intoMar 4, 2015
Conversation
Workflow XOML files call into IVsContainedLanguageFactory.GetLanguage(), passing an IVsTextBufferCoordinator. However, that IVsTextBufferCoordinator is constructed differently than the one we get from Venus and breaks some assumptions in the C#/VB language services. The critical assumption that XOML breaks is that the primary buffer is an IProjectionBuffer. This is not true for XOML. Instead, it is simply a non-projected buffer with the HTML content type. So, our code attempts to cast to an IProjectionBuffer and we crash before ever creating a ContainedDocument and adding it to the workspace. To fix this, we need to break the IProjectionBuffer assumption and update any calling code depending on projections to dynamically cast to IProjectionBuffer first. This unblocks several Workflow v1 scenarios. Next, it turns out that XOML never calls SetHost() on the IVsContainedLanguage that we return. So, there's never an IVsContainedLanguageHost hooked up and calling code needs to be updated to guard against null hosts.
Member
There was a problem hiding this comment.
Maybe an assert that _hostType == HostType.Razor so that the case below is safe?
Member
|
👍 |
Member
Author
|
@dotnet-bot test this please |
DustinCampbell
added a commit
that referenced
this pull request
Mar 4, 2015
Fix ContainedLanguage support for Workflow v1 XOML files
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
…typetag-from-vstemplates remove VSSDK template tag
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow XOML files call into IVsContainedLanguageFactory.GetLanguage(), passing an IVsTextBufferCoordinator. However, that IVsTextBufferCoordinator is constructed differently than the one we get from Venus and breaks some assumptions in the C#/VB language services.
The critical assumption that XOML breaks is that the primary buffer is an IProjectionBuffer. This is not true for XOML. Instead, it is simply a non-projected buffer with the HTML content type. So, our code attempts to cast to an IProjectionBuffer and we crash before ever creating a ContainedDocument and adding it to the workspace. To fix this, we need to break the IProjectionBuffer assumption and update any calling code depending on projections to dynamically cast to IProjectionBuffer first. This unblocks several Workflow v1 scenarios.
Next, it turns out that XOML never calls SetHost() on the IVsContainedLanguage that we return. So, there's never an IVsContainedLanguageHost hooked up and calling code needs to be updated to guard against null hosts.