Guard against null reference in AddImports - #1005
Merged
Merged
Conversation
Previously we weren't properly guarding against null reference exceptions when the symbol we try to add imports/usings for binds correctly.
Contributor
Author
|
@srivatsn @tmeschter @shyamnamboodiripad @mavasani @heejaechang @JohnHamby Could you take a look, please? |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
The code could be more compact and arguably no less readable with a ?: operator.
Contributor
|
I sign off. |
jmarolf
added a commit
that referenced
this pull request
Mar 4, 2015
Guard against null reference in AddImports
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Update dependencies to remove implicit Newtonsoft.Json 12.0.2 dependency
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we weren't properly guarding against null reference exceptions when the symbol we try to add Imports/usings for binds correctly.
Fixes #794